Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(csharp): include GetInfo and GetObjects call for .NET 4.7.2 #945

Merged
merged 3 commits into from
Jul 28, 2023
Merged

fix(csharp): include GetInfo and GetObjects call for .NET 4.7.2 #945

merged 3 commits into from
Jul 28, 2023

Conversation

davidhcoe
Copy link
Contributor

Continuation of #930

@davidhcoe davidhcoe requested a review from lidavidm as a code owner July 28, 2023 14:07
lidavidm
lidavidm approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (as far as I understand C#), except for the one comment

csharp/src/Apache.Arrow.Adbc/C/CAdbcDriverImporter.cs Show resolved Hide resolved
@lidavidm lidavidm merged commit 7933e16 into apache:main Jul 28, 2023
2 checks passed
@lidavidm lidavidm added this to the ADBC Libraries 0.6.0 milestone Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhcoe @lidavidm