Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(java): bump arrow to 18.0.0 #2293

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

laurentgo
Copy link
Contributor

Update arrow dependency from 15.0.0 to 18.0.0.

As Apache Arrow now requires Java 11, Apache Arrow ADBC also now requires Java 11.

Update Apache Parent pom to version 33 and take advantage of Java 9+ support.

Clean up pom.xml files to remove duplicate or conflicting plugin version definition and/or configuration

Update FlightSQL tests to use the FlightSQL Junit 5 extension.

Update build and dev scripts, and documentation

@lidavidm
Copy link
Member

Thanks! I'll review when I get back next week

@lidavidm
Copy link
Member

Note that it appears Java verification fails

@laurentgo
Copy link
Contributor Author

I do see multiple errors in C++ code with the following message though:

In file included from /adbc/c/driver/framework/utility.cc:24:
/adbc/c/vendor/nanoarrow/nanoarrow.hpp:95:35: error: identifier '_asv' preceded by whitespace in a literal operator declaration is deprecated [-Werror,-Wdeprecated-literal-operator]
   95 | inline ArrowStringView operator"" _asv(const char* data, std::size_t size_bytes) {
      |                        ~~~~~~~~~~~^~~~
      |                        operator""_asv
In file included from /adbc/c/driver/framework/objects.cc:22:
/adbc/c/vendor/nanoarrow/nanoarrow.hpp:95:35: error: identifier '_asv' preceded by whitespace in a literal operator declaration is deprecated [-Werror,-Wdeprecated-literal-operator]
   95 | inline ArrowStringView operator"" _asv(const char* data, std::size_t size_bytes) {
      |                        ~~~~~~~~~~~^~~~
      |                        operator""_asv
1 error generated.

and also

/Users/runner/work/arrow-adbc/arrow-adbc/c/driver/flightsql/sqlite_flightsql_test.cc:124:15: error: 'catalog' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
  124 |   std::string catalog() const { return "main"; }
      |               ^
/Users/runner/work/arrow-adbc/arrow-adbc/c/validation/adbc_validation.h:248:23: note: overridden virtual function is here
  248 |   virtual std::string catalog() const { return ""; }
      |                       ^
1 error generated.

it may be caused by my change but the cause is unclear to me as why. I'll try to rebase my change in case

There's also one maven-assembly-plugin error probably caused by the apache parent update (will debug and fix)

@laurentgo laurentgo force-pushed the laurentgo/arrow-java-18-update branch from b0e1dc7 to 32231b0 Compare October 31, 2024 01:51
@lidavidm
Copy link
Member

lidavidm commented Nov 5, 2024

The C++ errors aren't related, there are separate fixes for those

@lidavidm
Copy link
Member

lidavidm commented Nov 5, 2024

I would like to do a release soon so I may take the liberty of upgrading Arrow separately (without the parent POM change) in the meantime. Thanks for the help!

@laurentgo laurentgo force-pushed the laurentgo/arrow-java-18-update branch from 32231b0 to a64f2fb Compare November 5, 2024 17:33
@laurentgo
Copy link
Contributor Author

The maven change are a small part of the changes for arrow 18.0. Just pushed a rebased version

@lidavidm
Copy link
Member

lidavidm commented Nov 5, 2024

I think if you rebase, the CI errors should mostly go away!

Update arrow dependency from 15.0.0 to 18.0.0.

As Apache Arrow now requires Java 11, Apache Arrow ADBC also now
requires Java 11.

Update Apache Parent pom to version 33 and take advantage of Java 9+
support.

Clean up pom.xml files to remove duplicate or conflicting plugin version
definition and/or configuration

Update FlightSQL tests to use the FlightSQL Junit 5 extension.

Update build and dev scripts, and documentation
@laurentgo laurentgo force-pushed the laurentgo/arrow-java-18-update branch from 7b1ddca to 4143439 Compare November 6, 2024 05:43
@laurentgo
Copy link
Contributor Author

Pushed new rebase

Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lidavidm lidavidm merged commit 12a74af into apache:main Nov 6, 2024
75 of 79 checks passed
@laurentgo laurentgo deleted the laurentgo/arrow-java-18-update branch November 6, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants