Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: C++ Client Helpers #2274

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

feat: C++ Client Helpers #2274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a57535d
start client
paleolimbot Oct 17, 2024
b725c67
heiarchy
paleolimbot Oct 23, 2024
3b7a132
a go at the higher level
paleolimbot Oct 23, 2024
c7fd5c7
rename
paleolimbot Oct 23, 2024
e8445e2
heiarchy validity checking
paleolimbot Oct 23, 2024
524bf9d
even more lifecycle
paleolimbot Oct 23, 2024
7c9cbf6
better lifecycle
paleolimbot Oct 23, 2024
9cc2bef
test passed!
paleolimbot Oct 23, 2024
1b32a39
lint
paleolimbot Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 77 additions & 0 deletions c/driver/framework/base_driver_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

#include <arrow-adbc/adbc.h>
#include "driver/framework/base_driver.h"
#include "driver/framework/client.h"
#include "driver/framework/connection.h"
#include "driver/framework/database.h"
#include "driver/framework/statement.h"
Expand Down Expand Up @@ -235,3 +236,79 @@ TEST(TestDriverBase, TestVoidDriverMethods) {
ADBC_STATUS_INVALID_ARGUMENT);
EXPECT_EQ(driver.StatementCancel(&statement, nullptr), ADBC_STATUS_NOT_IMPLEMENTED);
}

class TestContext : public adbc::client::Context {
void Log(LogLevel level, std::string_view message) override {
GTEST_FAIL() << "Unexpected TestContext log message: " << message;
}
};

TEST(TestDriverBase, TestVoidDriverMethodsClient) {
using adbc::client::Connection;
using adbc::client::Database;
using adbc::client::Driver;
using adbc::client::Statement;

Driver driver(std::make_shared<TestContext>());
ASSERT_TRUE(driver.Load(VoidDriverInitFunc).ok());

auto maybe_database = driver.NewDatabase();
ASSERT_TRUE(maybe_database.has_value());
Database database = std::move(maybe_database.value());

// TODO: Test database methods

auto maybe_connection = database.NewConnection();
ASSERT_TRUE(maybe_connection.has_value()) << maybe_connection.status().message();
Connection connection = std::move(maybe_connection.value());

// TODO: Test connection methods

// EXPECT_EQ(driver.ConnectionCommit(&connection, nullptr), ADBC_STATUS_INVALID_STATE);
// EXPECT_EQ(driver.ConnectionGetInfo(&connection, nullptr, 0, nullptr, nullptr),
// ADBC_STATUS_INVALID_ARGUMENT);
// EXPECT_EQ(driver.ConnectionGetObjects(&connection, 0, nullptr, nullptr, 0, nullptr,
// nullptr, nullptr, nullptr),
// ADBC_STATUS_NOT_IMPLEMENTED);
// EXPECT_EQ(driver.ConnectionGetTableSchema(&connection, nullptr, nullptr, nullptr,
// nullptr, nullptr),
// ADBC_STATUS_INVALID_ARGUMENT);
// EXPECT_EQ(driver.ConnectionGetTableTypes(&connection, nullptr, nullptr),
// ADBC_STATUS_INVALID_ARGUMENT);
// EXPECT_EQ(driver.ConnectionReadPartition(&connection, nullptr, 0, nullptr, nullptr),
// ADBC_STATUS_NOT_IMPLEMENTED);
// EXPECT_EQ(driver.ConnectionRollback(&connection, nullptr),
// ADBC_STATUS_INVALID_STATE); EXPECT_EQ(driver.ConnectionCancel(&connection, nullptr),
// ADBC_STATUS_NOT_IMPLEMENTED); EXPECT_EQ(driver.ConnectionGetStatistics(&connection,
// nullptr, nullptr, nullptr, 0,
// nullptr, nullptr),
// ADBC_STATUS_NOT_IMPLEMENTED);
// EXPECT_EQ(driver.ConnectionGetStatisticNames(&connection, nullptr, nullptr),
// ADBC_STATUS_NOT_IMPLEMENTED);

auto maybe_statement = connection.NewStatement();
ASSERT_TRUE(maybe_statement.has_value());
Statement statement = std::move(maybe_statement.value());

// TODO: Test statement methods
// EXPECT_EQ(driver.StatementExecuteQuery(&statement, nullptr, nullptr, nullptr),
// ADBC_STATUS_INVALID_STATE);
// EXPECT_EQ(driver.StatementExecuteSchema(&statement, nullptr, nullptr),
// ADBC_STATUS_NOT_IMPLEMENTED);
// EXPECT_EQ(driver.StatementPrepare(&statement, nullptr), ADBC_STATUS_INVALID_STATE);
// EXPECT_EQ(driver.StatementSetSqlQuery(&statement, "", nullptr), ADBC_STATUS_OK);
// EXPECT_EQ(driver.StatementSetSubstraitPlan(&statement, nullptr, 0, nullptr),
// ADBC_STATUS_NOT_IMPLEMENTED);
// EXPECT_EQ(driver.StatementBind(&statement, nullptr, nullptr, nullptr),
// ADBC_STATUS_INVALID_ARGUMENT);
// EXPECT_EQ(driver.StatementBindStream(&statement, nullptr, nullptr),
// ADBC_STATUS_INVALID_ARGUMENT);
// EXPECT_EQ(driver.StatementCancel(&statement, nullptr), ADBC_STATUS_NOT_IMPLEMENTED);

ASSERT_EQ(statement.SetSqlQuery("").code(), ADBC_STATUS_OK);

ASSERT_EQ(statement.Release().code(), ADBC_STATUS_OK);
ASSERT_EQ(connection.Release().code(), ADBC_STATUS_OK);
ASSERT_EQ(database.Release().code(), ADBC_STATUS_OK);
ASSERT_EQ(driver.Unload().code(), ADBC_STATUS_OK);
}
Loading
Loading