Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(go/adbc/driver/snowflake): add '[ADBC]' to snowflake application name #1525

Merged
merged 6 commits into from
Feb 7, 2024
Merged

feat(go/adbc/driver/snowflake): add '[ADBC]' to snowflake application name #1525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0f2cac1
chore(snowflake): add '[ADBC]' to snowflake application name
zeroshade Feb 7, 2024
6aad000
don't override modify user's choice
zeroshade Feb 7, 2024
fcdbf1e
add default application name
zeroshade Feb 7, 2024
e97faff
fix prefix add version
zeroshade Feb 7, 2024
7d82a57
Update python/adbc_driver_snowflake/adbc_driver_snowflake/__init__.py
zeroshade Feb 7, 2024
8c9cc0f
lint
zeroshade Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions go/adbc/driver/snowflake/snowflake_database.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,11 @@ func (d *databaseImpl) SetOptions(cnOptions map[string]string) error {
}
}

defaultAppName := "[ADBC][Go-" + infoDriverVersion + "]"
// set default application name to track
// unless user overrides it
d.cfg.Application = defaultAppName

var err error
for k, v := range cnOptions {
v := v // copy into loop scope
Expand Down Expand Up @@ -265,6 +270,9 @@ func (d *databaseImpl) SetOptions(cnOptions map[string]string) error {
}
d.cfg.ClientTimeout = dur
case OptionApplicationName:
if !strings.HasPrefix(v, "[ADBC]") {
v = defaultAppName + v
}
d.cfg.Application = v
case OptionSSLSkipVerify:
switch v {
Expand Down
4 changes: 4 additions & 0 deletions python/adbc_driver_snowflake/adbc_driver_snowflake/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,10 @@ def connect(
kwargs = (db_kwargs or {}).copy()
if uri is not None:
kwargs["uri"] = uri
appname = kwargs.get(DatabaseOptions.APPLICATION_NAME.value, "")
kwargs[
DatabaseOptions.APPLICATION_NAME.value
] = f"[ADBC][Python-{__version__}]{appname}"
return adbc_driver_manager.AdbcDatabase(driver=_driver_path(), **kwargs)


Expand Down
Loading