fix: Ensure that test suite passes with system-provided SQLite on MacOS #1499
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opened up the C drivers and ran the tests and got a failing test: when the driver compiles against system SQLite on MacOS, extension loading is not allowed (the symbols aren't even provided nor defined in the header). I added a define to make sure the R package could build on MacOS, but the test needs it too.
I also added come CMake to check this...I also tried
check_sybmol_exists
but this seems to require settingCMAKE_REQUIRED_LIBRARIES
/includes which seems like it might have some global impact that we don't want. Checking for the text in the header does the trick for me (and is maybe less likely to result in accidentally building the library without extension support).The other failing test I saw before seems to have been cleared up by the SQLite driver refactor!
The
.cache
in the.gitignore
is because clangd seems to put a lot of files there.