feat(go/adbc)!: close database explicitly

[levakin]

Implicit database release behaves inconsistently on different OS, which leads to bugs.

BREAKING CHANGE: adds Close to the Database interface.
Closes #1306.

[lidavidm]

CC @zeroshade this affects the core definitions so we're going to want a different way to proceed.

[levakin]

@lidavidm do you mean adbc.Database cannot be extended?

[zeroshade]

@lidavidm Given that we're just adding a new method to an interface that it is not expected that others will be implementing outside of us, I think it's okay to just add the Close method to the interface along with the implementations.

[github-actions]

⚠️ Please follow the Conventional Commits format in CONTRIBUTING.md for PR titles.

[zeroshade]

Are the FlightSQL test failures related to this change or do they exist in main without this change?

[levakin]

I'll now rebase on the latest main. But I suppose new changes are causing an issue. Could you please look into it too @zeroshade ? I'll share if I find anything.

Failing job

[zeroshade]

@levakin one of the tests calls AdbcDatabaseNew and then immediately calls AdbcDatabaseRelease, meaning it's releasing an uninitialized database. the db member of the cDatabase object is only initialized when AdbcDatabaseInit is called, until then it is just nil. So you were calling cdb.db.Close() when cdb.db was nil.

So just needed to add a nil check there and all is well 😄

[levakin]

@zeroshade Nice! Thanks!
What is left to do to merge the PR?