Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(glib): Add Apache Arrow GLib integration library #1459

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

kou
Copy link
Member

@kou kou commented Jan 13, 2024

Fixes #1280.

We can use
GArrowRecordBatch/GArrowSchema/GArrowRecordBatchReader instead of C data API with this library.

@kou kou requested a review from lidavidm as a code owner January 13, 2024 23:38
@github-actions github-actions bot added this to the ADBC Libraries 0.10.0 milestone Jan 13, 2024
@kou
Copy link
Member Author

kou commented Jan 13, 2024

@esodan What do you think about this approach?

@kou kou force-pushed the glib-arrow branch 9 times, most recently from 6819271 to 0a1c31d Compare January 14, 2024 12:33
@esodan
Copy link
Contributor

esodan commented Jan 15, 2024

@esodan What do you think about this approach?

This is great! Clear API for GObject Introspection API. If there is more API using void* pointers, please consider then as candidates to go the same way. I'll try to test it and integrate them in my Vala library libvda

Fixes apache#1280.

We can use
`GArrowRecordBatch`/`GArrowSchema`/`GArrowRecordBatchReader` instead
of C data API with this library.
@kou
Copy link
Member Author

kou commented Jan 15, 2024

Thanks. I'll merge this once you don't find any problem with your libvda.

@kou
Copy link
Member Author

kou commented Jan 22, 2024

I'll merge this as-is for now.
If you have a problem with this, please open a new issue.

@kou kou merged commit 784d913 into apache:main Jan 22, 2024
49 checks passed
@kou kou deleted the glib-arrow branch January 22, 2024 22:04
soumyadsanyal pushed a commit to soumyadsanyal/arrow-adbc that referenced this pull request Jan 31, 2024
Fixes apache#1280.

We can use
`GArrowRecordBatch`/`GArrowSchema`/`GArrowRecordBatchReader` instead of
C data API with this library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve GADBC API to be GObject Introspection friendly
2 participants