fix(csharp/src/Client): improved support for AffectedRows #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
November 20, 2023 14:37
added 6 commits
January 15, 2024 19:52
|
Closing this PR after discussion with @CurtHagenlocher . The functionality that is introduced here would be better moved outside of the library because the functionality would be obsolete once ADBC supports multi statements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for multi-statements. If a caller wishes to use
ExecuteReaderand have RecordsAffected set for a DELETE command, they should use the new QueryDefinition functionality. This gives callers, who will be working with a specific driver, control over how certain keywords (CREATE, UPDATE, SELECT, DELETE, etc) should be handled, in addition to being able to define their own. If a QueryDefinition is not set, the default QueryResult behavior is used. Additionally, callers can override the parsing of multiple statements using the CustomParser property of the QueryConfiguration if they wish to override how multiple statements are parsed.Tests included - Yes
Resolves #1448