python: switch to static versioning for simplicity #1419
Conversation
We tried to derive versions from Git. But since we release off of a branch, this meant that all non-branch builds would have version 0.0.0. This breaks things like Polars that rely on checking the installed version. Instead, since we already bump versions as part of the release process, just hardcode the version and drop most of miniver. Fixes apache#1363.
|
|
|
I had originally picked miniver as a simpler version of versioneer; if they work roughly the same they probably have the same failure mode here |
|
I think bumping manually is certainly fine here (and I also don't do the releasing, so don't have an opinion on it), but just a small comment on:
I (help) maintain other projects that also do releases from a branch and do use versioneer. That in itself is not a problem, but that only means you need to tag the main branch as well, and not only the release branch (eg in pandas, when we make the release branch for eg 2.2.x, we tag the next commit on the main branch as 2.3.0.dev to ensure the main dev version is correctly "higher") |
|
Ah. That makes sense, though it feels a little synthetic. |
We tried to derive versions from Git. But since we release off of a branch, this meant that all non-branch builds would have version 0.0.0. This breaks things like Polars that rely on checking the installed version.
Instead, since we already bump versions as part of the release process, just hardcode the version and drop most of miniver.
Fixes #1363.