Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(csharp/test/Drivers/Interop/Snowflake): Updated the metadata tests to work without the db name #1352

Commits on Jan 2, 2024

  1. fix: Reduced SQL calls in GetObjects to two, added prefixing DbName f…

    …or INFORMATION_SCHEMA calls, and removed SQL cursor code
    
    Additional changes:
    * Reduced SQL calls by making only 1 - 2 SQL call based on the ObjectsDepth and using that data to populate all the previous depth information
    * There is one SHOW TERSE DATABASES that is always called and the catalogPattern is used to filter the databases and prepare the SQL based on the depth for schema, tables, or columns
    * The SQL cursor code was removed and the replaced with a static SQL that is prepared in Go based on the databases that match the catalogPattern
    * GetObjects populates the MetadataRecords by making the necessary SQL call based on ObjectsDepth
    * Modified the logic of GetObjects Init to pass MetadataRecords in getObjectsDbSchemas and getObjectsTables
    * Modified tests to check the table type returned
    ryan-syed committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    b76af78 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    12b9791 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    de548d7 View commit details
    Browse the repository at this point in the history
  4. refactor: Refactored SQL, made the code modular, and added tests for …

    …verifying the generated SQL
    ryan-syed committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    f274627 View commit details
    Browse the repository at this point in the history
  5. refactor: Refactored all the filter conditions for GetObjects into a …

    …single prepareFilterConditions function
    ryan-syed committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    564012b View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Configuration menu
    Copy the full SHA
    9c414c0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0530bd1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    00ed648 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'dev/ryansyed/fix_getobjects_withoutdbname_reducingsqlca…

    …lls_nocursor' of https://github.com/ryan-syed/arrow-adbc into dev/ryansyed/fix_getobjects_withoutdbname_reducingsqlcalls_nocursor
    ryan-syed committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    bc0d5c9 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'dev/ryansyed/fix_getobjects_withoutdbname_reducingsqlca…

    …lls_nocursor' of https://github.com/ryan-syed/arrow-adbc into dev/ryansyed/fix_getobjects_withoutdbname_reducingsqlcalls_nocursor
    ryan-syed committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    c0387c4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7f506a0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8d8345e View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Merge branch 'dev/ryansyed/fix_getobjects_withoutdbname_reducingsqlca…

    …lls_nocursor' of https://github.com/ryan-syed/arrow-adbc into dev/ryansyed/fix_getobjects_withoutdbname_reducingsqlcalls_nocursor
    ryan-syed committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    65a99d6 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. removed white space changes

    ryan-syed committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    721f3b0 View commit details
    Browse the repository at this point in the history