-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(csharp/test/Drivers/Interop/Snowflake): Updated the metadata tests to work without the db name #1352
Commits on Jan 2, 2024
-
fix: Reduced SQL calls in GetObjects to two, added prefixing DbName f…
…or INFORMATION_SCHEMA calls, and removed SQL cursor code Additional changes: * Reduced SQL calls by making only 1 - 2 SQL call based on the ObjectsDepth and using that data to populate all the previous depth information * There is one SHOW TERSE DATABASES that is always called and the catalogPattern is used to filter the databases and prepare the SQL based on the depth for schema, tables, or columns * The SQL cursor code was removed and the replaced with a static SQL that is prepared in Go based on the databases that match the catalogPattern * GetObjects populates the MetadataRecords by making the necessary SQL call based on ObjectsDepth * Modified the logic of GetObjects Init to pass MetadataRecords in getObjectsDbSchemas and getObjectsTables * Modified tests to check the table type returned
Configuration menu - View commit details
-
Copy full SHA for b76af78 - Browse repository at this point
Copy the full SHA b76af78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12b9791 - Browse repository at this point
Copy the full SHA 12b9791View commit details -
Configuration menu - View commit details
-
Copy full SHA for de548d7 - Browse repository at this point
Copy the full SHA de548d7View commit details -
refactor: Refactored SQL, made the code modular, and added tests for …
…verifying the generated SQL
Configuration menu - View commit details
-
Copy full SHA for f274627 - Browse repository at this point
Copy the full SHA f274627View commit details -
refactor: Refactored all the filter conditions for GetObjects into a …
…single prepareFilterConditions function
Configuration menu - View commit details
-
Copy full SHA for 564012b - Browse repository at this point
Copy the full SHA 564012bView commit details
Commits on Jan 3, 2024
-
Merge branch 'main' into dev/ryansyed/fix_getobjects_withoutdbname_re…
…ducingsqlcalls_nocursor
Configuration menu - View commit details
-
Copy full SHA for 9c414c0 - Browse repository at this point
Copy the full SHA 9c414c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0530bd1 - Browse repository at this point
Copy the full SHA 0530bd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00ed648 - Browse repository at this point
Copy the full SHA 00ed648View commit details -
Merge branch 'dev/ryansyed/fix_getobjects_withoutdbname_reducingsqlca…
…lls_nocursor' of https://github.com/ryan-syed/arrow-adbc into dev/ryansyed/fix_getobjects_withoutdbname_reducingsqlcalls_nocursor
Configuration menu - View commit details
-
Copy full SHA for bc0d5c9 - Browse repository at this point
Copy the full SHA bc0d5c9View commit details -
Merge branch 'dev/ryansyed/fix_getobjects_withoutdbname_reducingsqlca…
…lls_nocursor' of https://github.com/ryan-syed/arrow-adbc into dev/ryansyed/fix_getobjects_withoutdbname_reducingsqlcalls_nocursor
Configuration menu - View commit details
-
Copy full SHA for c0387c4 - Browse repository at this point
Copy the full SHA c0387c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f506a0 - Browse repository at this point
Copy the full SHA 7f506a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d8345e - Browse repository at this point
Copy the full SHA 8d8345eView commit details
Commits on Jan 4, 2024
-
Merge branch 'dev/ryansyed/fix_getobjects_withoutdbname_reducingsqlca…
…lls_nocursor' of https://github.com/ryan-syed/arrow-adbc into dev/ryansyed/fix_getobjects_withoutdbname_reducingsqlcalls_nocursor
Configuration menu - View commit details
-
Copy full SHA for 65a99d6 - Browse repository at this point
Copy the full SHA 65a99d6View commit details
Commits on Jan 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 721f3b0 - Browse repository at this point
Copy the full SHA 721f3b0View commit details