feat(go/adbc/driver/snowflake): add support for ExecuteSchema #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CurtHagenlocher
commented
Nov 6, 2023
| @@ -236,15 +236,15 @@ func (s *SnowflakeQuirks) SampleTableSchemaMetadata(tblName string, dt arrow.Dat | |||
| return arrow.Metadata{} | |||
| } | |||
|
|
|||
| func createTempSchema(uri string) string { | |||
| func createTempSchema(database string, uri string) string { | |||
There was a problem hiding this comment.
This is unrelated test cleanup.
CurtHagenlocher
commented
Nov 6, 2023
lidavidm
approved these changes
Nov 6, 2023
Comment on lines
587
to
591
| // ExecuteQuery executes the current query or prepared statement | ||
| // and returnes a RecordReader for the results along with the number | ||
| // of rows affected if known, otherwise it will be -1. | ||
| // | ||
| // This invalidates any prior result sets on this statement. |
There was a problem hiding this comment.
nit: docstring is out of sync (IMO, it's not necessary here since you would only use it through the interface)
There was a problem hiding this comment.
It felt inconsistent with the other functions not to include it (assuming, ahem, I'd remembered to edit it...).
lidavidm
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1254.