refactor(r): Improve testing for ADBC 1.1 features in R bindings #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paleolimbot
force-pushed
the
r-options-testing
branch
from
4e225cb
to
102807e
Compare
…functions intended to be used from C
paleolimbot
force-pushed
the
r-options-testing
branch
from
608c12c
to
1fccb0f
Compare
zeroshade
requested changes
Oct 25, 2023
|
|
||
| explicit Error(const char* message) : Error(std::string(message)) {} | ||
|
|
||
| Error(const std::string& message, |
There was a problem hiding this comment.
I think this one doesn't need it because there's two arguments to the constructor?
There was a problem hiding this comment.
fair point, we aren't using default args for the second argument so you're right.
zeroshade
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements option setting/getting in the "void" driver and implements tests for the full grid of set/get by string/bytes/integer/double by database/connection/statement. The error detail information was also not implemented in the dummy driver and so couldn't be tested (so there is an implementation of that here).
Implementing a driver that actually did this was sufficient work that I did some rather heavy abstraction to make it easier to write. That abstraction is not unlike a "driver framework" except it is (1) not complete, since the void driver only needs options methods and (2) doesn't provide any result helpers (building streams, etc.). It might be worth porting the driver base to be more general but for now I'd like to keep it constrained to what I need to test in R.
Closes #1126.