Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(c/driver/postgresql): String/Large String COPY Writers #1172

Merged
merged 1 commit into from
Oct 6, 2023
Merged

feat(c/driver/postgresql): String/Large String COPY Writers #1172

merged 1 commit into from
Oct 6, 2023

Conversation

WillAyd
Copy link
Contributor

@WillAyd WillAyd commented Oct 6, 2023

No description provided.

@WillAyd WillAyd requested a review from lidavidm as a code owner October 6, 2023 13:20
WillAyd
WillAyd commented Oct 6, 2023
View reviewed changes
c/driver/postgresql/postgres_copy_reader_test.cc
}
}

TEST(PostgresCopyUtilsTest, PostgresCopyWriteLargeString) {
Copy link
Contributor Author

@WillAyd WillAyd Oct 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty much copy/paste from the above test just changing the type; could alternately be a fixture

@lidavidm lidavidm merged commit 1d5501a into apache:main Oct 6, 2023
44 checks passed
@lidavidm lidavidm added this to the ADBC Libraries 0.8.0 milestone Oct 6, 2023
@WillAyd WillAyd deleted the copy-text branch October 9, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@WillAyd @lidavidm