Skip to content

Commit

Permalink
ci: build wheels with debug info
Browse files Browse the repository at this point in the history
Fixes #1583.
  • Loading branch information
lidavidm committed Mar 20, 2024
1 parent 8768cd2 commit fd61eb5
Show file tree
Hide file tree
Showing 14 changed files with 4,676 additions and 9 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/packaging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -876,6 +876,7 @@ jobs:
adbc/python/adbc_driver_postgresql/repaired_wheels/*.whl
adbc/python/adbc_driver_sqlite/repaired_wheels/*.whl
adbc/python/adbc_driver_snowflake/repaired_wheels/*.whl
adbc/build/**/*.pdb
- name: Test wheel
shell: cmd
Expand Down Expand Up @@ -965,13 +966,16 @@ jobs:
RELEASE_TAG=${GITHUB_REF#refs/*/}
# Deduplicate wheels built in different jobs with same tag
# Include .pdb files since those are debug symbols for Windows
# wheels
mkdir -p upload-staging
find ./release-artifacts/ \
'(' \
-name docs.tgz -or \
-name '*.jar' -or \
-name '*.nupkg' -or \
-name '*.snupkg' -or \
-name '*.pdb' -or \
-name '*.pom' -or \
-name '*.whl' -or \
-name 'adbc_*.tar.gz' -or \
Expand Down
13 changes: 6 additions & 7 deletions c/driver/sqlite/statement_reader.c
Original file line number Diff line number Diff line change
Expand Up @@ -608,15 +608,14 @@ int StatementReaderGetOneValue(struct StatementReader* reader, int col,
return ArrowArrayAppendBytes(out, value);
}

default: {
snprintf(reader->error.message, sizeof(reader->error.message),
"[SQLite] Internal error: unknown inferred column type %d",
reader->types[col]);
return ENOTSUP;
}
default:
break;
}

return 0;
snprintf(reader->error.message, sizeof(reader->error.message),
"[SQLite] Internal error: unknown inferred column type %d",
reader->types[col]);
return ENOTSUP;
}

int StatementReaderGetNext(struct ArrowArrayStream* self, struct ArrowArray* out) {
Expand Down
21 changes: 21 additions & 0 deletions c/vendor/backward/LICENSE.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
Copyright 2013 Google Inc. All Rights Reserved.

The MIT License (MIT)

Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal in
the Software without restriction, including without limitation the rights to
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
of the Software, and to permit persons to whom the Software is furnished to do
so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
42 changes: 42 additions & 0 deletions c/vendor/backward/backward.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
// Pick your poison.
//
// On GNU/Linux, you have few choices to get the most out of your stack trace.
//
// By default you get:
// - object filename
// - function name
//
// In order to add:
// - source filename
// - line and column numbers
// - source code snippet (assuming the file is accessible)

// Install one of the following libraries then uncomment one of the macro (or
// better, add the detection of the lib and the macro definition in your build
// system)

// - apt-get install libdw-dev ...
// - g++/clang++ -ldw ...
// #define BACKWARD_HAS_DW 1

// - apt-get install binutils-dev ...
// - g++/clang++ -lbfd ...
// #define BACKWARD_HAS_BFD 1

// - apt-get install libdwarf-dev ...
// - g++/clang++ -ldwarf ...
// #define BACKWARD_HAS_DWARF 1

// Regardless of the library you choose to read the debug information,
// for potentially more detailed stack traces you can use libunwind
// - apt-get install libunwind-dev
// - g++/clang++ -lunwind
// #define BACKWARD_HAS_LIBUNWIND 1

#include "backward.hpp"

namespace backward {

backward::SignalHandling sh;

} // namespace backward
Loading

0 comments on commit fd61eb5

Please sign in to comment.