ci: build wheels with debug info (#1599)

Fixes #1583.

.github/workflows/packaging.yml

@@ -876,6 +876,7 @@ jobs:
             adbc/python/adbc_driver_postgresql/repaired_wheels/*.whl
             adbc/python/adbc_driver_sqlite/repaired_wheels/*.whl
             adbc/python/adbc_driver_snowflake/repaired_wheels/*.whl
+            adbc/build/**/*.pdb
 
       - name: Test wheel
         shell: cmd
@@ -965,13 +966,16 @@ jobs:
           RELEASE_TAG=${GITHUB_REF#refs/*/}
 
           # Deduplicate wheels built in different jobs with same tag
+          # Include .pdb files since those are debug symbols for Windows
+          # wheels
           mkdir -p upload-staging
           find ./release-artifacts/ \
             '(' \
               -name docs.tgz -or \
               -name '*.jar' -or \
               -name '*.nupkg' -or \
               -name '*.snupkg' -or \
+              -name '*.pdb' -or \
               -name '*.pom' -or \
               -name '*.whl' -or \
               -name 'adbc_*.tar.gz' -or \

LICENSE.txt

@@ -307,6 +307,33 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 --------------------------------------------------------------------------------
 
+3rdparty dependency backward-cpp is statically linked in certain binary
+distributions, like the Python wheels. backward-cpp has the following license:
+
+Copyright 2013 Google Inc. All Rights Reserved.
+
+The MIT License (MIT)
+
+Permission is hereby granted, free of charge, to any person obtaining a copy of
+this software and associated documentation files (the "Software"), to deal in
+the Software without restriction, including without limitation the rights to
+use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
+of the Software, and to permit persons to whom the Software is furnished to do
+so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.
+
+--------------------------------------------------------------------------------
+
 3rdparty dependency libpq is statically linked in certain binary
 distributions, like the Python wheels. libpq has the following license:
 

c/cmake_modules/AdbcDefines.cmake

@@ -79,6 +79,7 @@ if(MSVC)
   add_compile_options(/wd4100)
   # Nanoarrow emits a lot of conversion warnings
   add_compile_options(/wd4365)
+  add_compile_options(/wd4242)
   add_compile_options(/wd4458)
   add_compile_options(/wd4514)
   add_compile_options(/wd4582)

c/driver/framework/status.h

@@ -129,7 +129,7 @@ class Status {
   template <typename DatabaseT, typename ConnectionT, typename StatementT>
   friend class Driver;
 
-  int CDetailCount() const { return impl_ ? impl_->details.size() : 0; }
+  int CDetailCount() const { return impl_ ? static_cast<int>(impl_->details.size()) : 0; }
 
   AdbcErrorDetail CDetail(int index) const {
     if (!impl_ || index < 0 || static_cast<size_t>(index) >= impl_->details.size()) {

c/driver/sqlite/sqlite.cc

@@ -427,7 +427,8 @@ struct SqliteGetObjectsHelper : public driver::GetObjectsHelper {
     ColumnXdbc xdbc;
     bool notnull = sqlite3_column_int(columns->stmt(), 3) != 0;
     xdbc.xdbc_type_name = GetColumnText(columns->stmt(), 2);
-    xdbc.xdbc_nullable = notnull ? 0 : 1;
+    xdbc.xdbc_nullable =
+        notnull ? std::make_optional<int16_t>(0) : std::make_optional<int16_t>(1);
     if (sqlite3_column_type(columns->stmt(), 4) != SQLITE_NULL) {
       xdbc.xdbc_column_def = GetColumnText(columns->stmt(), 4);
     }

c/driver/sqlite/statement_reader.c

@@ -608,15 +608,14 @@ int StatementReaderGetOneValue(struct StatementReader* reader, int col,
       return ArrowArrayAppendBytes(out, value);
     }
 
-    default: {
-      snprintf(reader->error.message, sizeof(reader->error.message),
-               "[SQLite] Internal error: unknown inferred column type %d",
-               reader->types[col]);
-      return ENOTSUP;
-    }
+    default:
+      break;
   }
 
-  return 0;
+  snprintf(reader->error.message, sizeof(reader->error.message),
+           "[SQLite] Internal error: unknown inferred column type %d",
+           reader->types[col]);
+  return ENOTSUP;
 }
 
 int StatementReaderGetNext(struct ArrowArrayStream* self, struct ArrowArray* out) {

c/vendor/backward/LICENSE.txt

@@ -0,0 +1,21 @@
+Copyright 2013 Google Inc. All Rights Reserved.
+
+The MIT License (MIT)
+
+Permission is hereby granted, free of charge, to any person obtaining a copy of
+this software and associated documentation files (the "Software"), to deal in
+the Software without restriction, including without limitation the rights to
+use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
+of the Software, and to permit persons to whom the Software is furnished to do
+so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

c/vendor/backward/backward.cpp

@@ -0,0 +1,42 @@
+// Pick your poison.
+//
+// On GNU/Linux, you have few choices to get the most out of your stack trace.
+//
+// By default you get:
+//	- object filename
+//	- function name
+//
+// In order to add:
+//	- source filename
+//	- line and column numbers
+//	- source code snippet (assuming the file is accessible)
+
+// Install one of the following libraries then uncomment one of the macro (or
+// better, add the detection of the lib and the macro definition in your build
+// system)
+
+// - apt-get install libdw-dev ...
+// - g++/clang++ -ldw ...
+// #define BACKWARD_HAS_DW 1
+
+// - apt-get install binutils-dev ...
+// - g++/clang++ -lbfd ...
+// #define BACKWARD_HAS_BFD 1
+
+// - apt-get install libdwarf-dev ...
+// - g++/clang++ -ldwarf ...
+// #define BACKWARD_HAS_DWARF 1
+
+// Regardless of the library you choose to read the debug information,
+// for potentially more detailed stack traces you can use libunwind
+// - apt-get install libunwind-dev
+// - g++/clang++ -lunwind
+// #define BACKWARD_HAS_LIBUNWIND 1
+
+#include "backward.hpp"
+
+namespace backward {
+
+backward::SignalHandling sh;
+
+} // namespace backward