Skip to content

Commit

Permalink
ci: build wheels with debug info
Browse files Browse the repository at this point in the history
Fixes #1583.
  • Loading branch information
lidavidm committed Mar 18, 2024
1 parent aba748f commit 2e7413e
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 9 deletions.
13 changes: 6 additions & 7 deletions c/driver/sqlite/statement_reader.c
Original file line number Diff line number Diff line change
Expand Up @@ -608,15 +608,14 @@ int StatementReaderGetOneValue(struct StatementReader* reader, int col,
return ArrowArrayAppendBytes(out, value);
}

default: {
snprintf(reader->error.message, sizeof(reader->error.message),
"[SQLite] Internal error: unknown inferred column type %d",
reader->types[col]);
return ENOTSUP;
}
default:
break;
}

return 0;
snprintf(reader->error.message, sizeof(reader->error.message),
"[SQLite] Internal error: unknown inferred column type %d",
reader->types[col]);
return ENOTSUP;
}

int StatementReaderGetNext(struct ArrowArrayStream* self, struct ArrowArray* out) {
Expand Down
2 changes: 1 addition & 1 deletion ci/scripts/python_util.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ function build_drivers {
local -r source_dir="$1"
local -r build_dir="$2/${VCPKG_ARCH}"

: ${CMAKE_BUILD_TYPE:=release}
: ${CMAKE_BUILD_TYPE:=RelWithDebInfo}
: ${CMAKE_UNITY_BUILD:=ON}
: ${CMAKE_GENERATOR:=Ninja}
: ${VCPKG_ROOT:=/opt/vcpkg}
Expand Down
3 changes: 3 additions & 0 deletions ci/scripts/python_wheel_unix_build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ check_visibility $ADBC_SNOWFLAKE_LIBRARY
# Get the latest pip so we have in-tree-build by default
python -m pip install --upgrade pip auditwheel cibuildwheel delocate setuptools wheel

# Build with Cython debug info
export ADBC_BUILD_TYPE="debug"

for component in $COMPONENTS; do
pushd ${source_dir}/python/$component

Expand Down
5 changes: 4 additions & 1 deletion ci/scripts/python_wheel_windows_build.bat
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ set build_dir=%2

echo "=== (%PYTHON_VERSION%) Building ADBC libpq driver ==="

set CMAKE_BUILD_TYPE=release
set CMAKE_BUILD_TYPE=RelWithDebInfo
set CMAKE_GENERATOR=Visual Studio 17 2022
set CMAKE_GENERATOR_PLATFORM=x64
set CMAKE_UNITY_BUILD=ON
Expand Down Expand Up @@ -61,6 +61,9 @@ set ADBC_POSTGRESQL_LIBRARY=%build_dir%\bin\adbc_driver_postgresql.dll
set ADBC_SQLITE_LIBRARY=%build_dir%\bin\adbc_driver_sqlite.dll
set ADBC_SNOWFLAKE_LIBRARY=%build_dir%\bin\adbc_driver_snowflake.dll

# Build with Cython debug info
set ADBC_BUILD_TYPE=debug

popd

python -m pip install --upgrade pip delvewheel wheel || exit /B 1
Expand Down

0 comments on commit 2e7413e

Please sign in to comment.