Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nacos): add skipped nil check for "applications" upvalue #9960

Merged
merged 4 commits into from
Aug 8, 2023
Merged

fix(nacos): add skipped nil check for "applications" upvalue #9960

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6a9f0b
fix: add skipped nil check for "applications" upvalue
Revolyssup Aug 3, 2023
ff0d34f
fix lint
Revolyssup Aug 3, 2023
a3d6011
add four space
Revolyssup Aug 3, 2023
c21430d
Merge remote-tracking branch 'upstream/master' into revolyssup/9527
Revolyssup Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apisix/discovery/nacos/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,8 +361,9 @@ function _M.nodes(service_name, discovery_args)
waiting_time = waiting_time - step
end

if not applications or not applications[namespace_id] or not applications[namespace_id][group_name] then
return nil
if not applications or not applications[namespace_id]
or not applications[namespace_id][group_name] then
return nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

four spaces are needed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

if not applications or not applications[namespace_id]
    or not applications[namespace_id][group_name] 
then
    return nil

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

end
return applications[namespace_id][group_name][service_name]
end
Expand Down
Loading