-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove check of OpenResty in code because APISIX can not start when using an old version of OpenResty #9926
Conversation
…overy Signed-off-by: ashing <[email protected]>
@ronething The purpose of this PR is to no longer be compatible with older versions of OpenResty? I think you need a better title of this PR. |
@moonming Hello,
due to this PR #9913 merge, we don't need to check OpenResty support ngx.process in the stream subsystem or not because we use OpenResty version >= 1.21.4.
maybe change the PR description is enough? if we need to change the PR title, what's better? Addition, can you approve the workflow? |
Yes. How about |
title changed, but CI failed. please rerun it when you have time, thanks. |
I think you misunderstood this pr: #9913. |
ok,but i wonder if we use the master branch code with apisix-base version lower than 1.21 after PR #9913,can we start the apisix successfully? |
I'm not sure. |
@ronething I found that the limitation has been add in #9913. |
LGTM |
@monkeyDluffy6017 ok, can you please rerun the cancelled job? |
Description
Fixes # (issue)
due to this PR #9913 merge, we don't need to check OpenResty support ngx.process in the stream subsystem or not because we use OpenResty version >= 1.21.4.
Checklist