-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add example for protos #9902
Merged
monkeyDluffy6017
merged 3 commits into
apache:master
from
shreemaan-abhishek:docs/protos
Jul 26, 2023
Merged
docs: add example for protos #9902
monkeyDluffy6017
merged 3 commits into
apache:master
from
shreemaan-abhishek:docs/protos
Jul 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/en/latest/deployment-modes.md
Outdated
Comment on lines
445
to
454
syntax = "proto3"; | ||
package helloworld; | ||
service Greeter { | ||
rpc SayHello (HelloRequest) returns (HelloReply) {} | ||
} | ||
message HelloRequest { | ||
string name = 1; | ||
} | ||
message HelloReply { | ||
string message = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need indent and blank here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦🏼♂️ yes, I just pushed my changes.
monkeyDluffy6017
added
the
wait for update
wait for the author's response in this issue/PR
label
Jul 26, 2023
nfrankel
reviewed
Jul 26, 2023
nfrankel
approved these changes
Jul 26, 2023
monkeyDluffy6017
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref: https://the-asf.slack.com/archives/CUC5MN17A/p1690309561460119?thread_ts=1690230991.755169&cid=CUC5MN17A
Checklist