Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(splunk-logger): allow configuring keepalive_timeout #11611

Merged
merged 3 commits into from
Sep 30, 2024
Merged

feat(splunk-logger): allow configuring keepalive_timeout #11611

merged 3 commits into from
Sep 30, 2024

Conversation

shreemaan-abhishek
Copy link
Contributor

Description

The default keepalive timeout is too long and will lead to lot of sockets left open in high scale.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request plugin labels Sep 26, 2024
moonming
moonming previously approved these changes Sep 26, 2024
View reviewed changes
nic-6443
nic-6443 previously approved these changes Sep 27, 2024
View reviewed changes
Revolyssup
Revolyssup previously approved these changes Sep 27, 2024
View reviewed changes
membphis
membphis reviewed Sep 27, 2024
View reviewed changes
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing test case

membphis
membphis requested changes Sep 27, 2024
View reviewed changes
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need some test case to confirm the changing

@shreemaan-abhishek
Copy link
Contributor Author

@membphis how to write test case for keepalive timeout?

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Sep 27, 2024
@shreemaan-abhishek shreemaan-abhishek merged commit 63046a8 into apache:master Sep 30, 2024
33 checks passed
@shreemaan-abhishek shreemaan-abhishek deleted the splunk-keepalive branch September 30, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Revolyssup Revolyssup Revolyssup approved these changes

@moonming moonming moonming approved these changes

@membphis membphis membphis approved these changes

@nic-6443 nic-6443 Awaiting requested review from nic-6443

Assignees
No one assigned
Labels
enhancement New feature or request plugin size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shreemaan-abhishek @membphis @nic-6443 @moonming @Revolyssup