Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: encryption/decryption for non-auth plugins in consumer #11600

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

ronething
Copy link
Contributor

Description

Fixes # (issue)

The data plane did not properly handle encryption and decryption when configuring a non authentication plugin on a consumer. This bug resulted in error logs and lack of encryption of sensitive information about the configuration of such plugins in etcd.

error log like:

[lua] plugin.lua:1027: decrypt_conf(): failed to get schema for plugin: csrf, context: ngx.timer"

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@ronething ronething marked this pull request as ready for review September 24, 2024 09:22
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 24, 2024
@dosubot dosubot bot added the bug Something isn't working label Sep 24, 2024
@ronething ronething merged commit d38d5b6 into apache:master Sep 25, 2024
31 checks passed
@ronething ronething deleted the fix/none_auth_plugin_in_consumer branch September 25, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants