fix: httpc connection close #11450
Open
fix: httpc connection close #11450
+93
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
great catch 🙏🏼 , could you please check if this bug exists in other plugins/places too? |
madhawa-gunasekara
force-pushed
the
issue-11449
branch
2 times, most recently
from
c331336
to
72ca229
Compare
zhoujiexiong
reviewed
Aug 1, 2024
apisix/plugins/authz-casdoor.lua
Outdated
| @@ -60,7 +61,7 @@ local function fetch_access_token(code, conf) | |||
| ["Content-Type"] = "application/x-www-form-urlencoded" | |||
| } | |||
| }) | |||
|
|
|||
| connection_util.close_http_connection(client) | |||
There was a problem hiding this comment.
request_uri will close(sock) before returning, so this line is not necessary? The same is true elsewhere of the PR.
There was a problem hiding this comment.
+1 will remove it.
|
@madhawa-gunasekara, please avoid force pushing 🙂 I have told this before. |
|
Ping @madhawa-gunasekara :D |
|
Ping @madhawa-gunasekara :D |
|
Hi @zhoujiexiong, I was traveling, I will push the changes. :) |
madhawa-gunasekara
force-pushed
the
issue-11449
branch
from
72ca229
to
9b0e489
Compare
dosubot
bot
added
the
size:L
|
@zhoujiexiong I did the changes.. please review |
madhawa-gunasekara
force-pushed
the
issue-11449
branch
from
97c45c1
to
dbf770c
Compare
|
@zhoujiexiong Ping, any chance to look into this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will close httpc connection. We observed too many connections in activemq.
Fixes #11449
Checklist