fix(schema): the port value greater than 65535 should not be allowed #11043

xuruidong · 2024-03-14T10:33:41Z

Fixes # (issue)

I have explained the need for this PR and the problem it solves
I have explained the changes or the new features added to this PR
I have added tests corresponding to this change
I have updated the documentation to reflect this change
I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

Revolyssup · 2024-03-15T06:57:25Z

@xuruidong Can you add a test case for this? Some test where you show that passing a port of higher number fails schema validation.

Signed-off-by: xuruidong <[email protected]>

zll600 · 2024-03-21T00:54:31Z

fix(schema): the port value greater than 65535 should not be allowed

3205a48

Revolyssup added the need test cases label Mar 15, 2024

xuruidong marked this pull request as draft March 15, 2024 07:55

refactor: check port

1725d9d

Signed-off-by: xuruidong <[email protected]>

xuruidong marked this pull request as ready for review March 19, 2024 08:09

test: add test for invalid port

1d388ab

Signed-off-by: xuruidong <[email protected]>

xuruidong force-pushed the patch-1 branch from aeaffb9 to 1d388ab Compare March 19, 2024 08:42

shreemaan-abhishek approved these changes Mar 21, 2024

View reviewed changes

Revolyssup approved these changes Mar 21, 2024

View reviewed changes

moonming approved these changes Mar 21, 2024

View reviewed changes

shreemaan-abhishek removed the need test cases label Mar 21, 2024

shreemaan-abhishek approved these changes Mar 21, 2024

View reviewed changes

shreemaan-abhishek merged commit c0e3d91 into apache:master Mar 21, 2024
53 checks passed

xuruidong deleted the patch-1 branch March 22, 2024 01:59

Provide feedback