feat(control): add plugins/reload to control api #10905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
starsz
reviewed
Feb 4, 2024
|
You mean |
monkeyDluffy6017
added
the
wait for update
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
|
@monkeyDluffy6017 @starsz please review |
starsz
reviewed
Feb 6, 2024
|
Do we need to remove the old API? |
|
Can you describe in detail why do you submit this pr? |
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
starsz
reviewed
Feb 7, 2024
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
starsz
previously approved these changes
Feb 7, 2024
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
starsz
previously approved these changes
Feb 7, 2024
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
starsz
reviewed
Feb 18, 2024
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
starsz
approved these changes
Feb 19, 2024
monkeyDluffy6017
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
plugin/reloadis under admin API. The admin API can only be called at the control plane (if we set the role to control plane). But we need to call the plugin/reload API at the data plane, so if we set the role of the apisix to data plane we can't call this API.This PR moves the
plugins/reloadto Control API so that we can call the endpoint from the data plane. For compatibility reasons, we also need to retain this API in admin API.Refer: https://apisix.apache.org/docs/apisix/admin-api/#plugin
Checklist