Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: when delete the secret cause 500 error #10902

Merged
merged 4 commits into from
Feb 21, 2024
Merged

fix: when delete the secret cause 500 error #10902

merged 4 commits into from
Feb 21, 2024

Conversation

hanqingwu
Copy link
Contributor

@hanqingwu hanqingwu commented Feb 2, 2024 •
edited
Loading

Description

Fixes #10823

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@hanqingwu hanqingwu changed the title Fix: when delete the secret cause 500 error fix: when delete the secret cause 500 error Feb 2, 2024
@monkeyDluffy6017
Copy link
Contributor

Test cases are needed

@shreemaan-abhishek shreemaan-abhishek added wait for update wait for the author's response in this issue/PR need test cases labels Feb 5, 2024
@shreemaan-abhishek
Copy link
Contributor

pls fix the CI

@monkeyDluffy6017
Copy link
Contributor

@soulbird please help to check

@monkeyDluffy6017 monkeyDluffy6017 mentioned this pull request Feb 7, 2024
Closed
soulbird
soulbird previously approved these changes Feb 7, 2024
View reviewed changes
@monkeyDluffy6017 monkeyDluffy6017 added approved and removed wait for update wait for the author's response in this issue/PR need test cases labels Feb 20, 2024
@shreemaan-abhishek shreemaan-abhishek merged commit 1d57986 into apache:master Feb 21, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreemaan-abhishek shreemaan-abhishek shreemaan-abhishek approved these changes

@monkeyDluffy6017 monkeyDluffy6017 monkeyDluffy6017 approved these changes

@soulbird soulbird Awaiting requested review from soulbird

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: use secret can cause 500 stack error in some case.
4 participants
@hanqingwu @monkeyDluffy6017 @shreemaan-abhishek @soulbird