-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to include request body and response body in log util #10888
Conversation
@shreemaan-abhishek Please help to check, thanks |
@shreemaan-abhishek I don’t think the ci error is caused by this PR, please help check. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please provide test cases for other plugnis as well.
@shreemaan-abhishek Can the test cases be completed by adding logs in the plug-in? I can't seem to use assertions without increasing the log |
@smileby I didn't get you. |
@smileby please resolve the conflicts |
Thanks for the reminder, I have solved it |
@shreemaan-abhishek I added the info log in the plug-in to facilitate me to write test cases. The code has been submitted, please help to check, thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Description
Fixes #10803
The request body and response body related attributes are added to the log plug-in. The list is as follows:
upplement the description of existing attributes missing in the Chinese document. The list is as follows:
Checklist