chore: Remove the shell and docs for build/install APISIX on MacOS #10864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vacant2333 <[email protected]>
|
@membphis hi! can u help me take a look about the solution? |
membphis
reviewed
Jan 23, 2024
| # Install dependencies on mac osx | ||
| function install_dependencies_on_mac_osx() { | ||
| # install OpenResty, etcd and some compilation tools | ||
| brew install openresty/brew/openresty luarocks [email protected] wget curl git pcre openldap |
There was a problem hiding this comment.
I think we can throw an warning message, it more friendly
There was a problem hiding this comment.
hi, i have update this, in fact, if it is Mac in this logic, it will indicate that the current platform is not supported, so I did not add a new prompt.
But there is another problem with this code. Even the unsupported platform make deps will continue to execute, so I added an exit 1 to interrupt it.
the result will be like:
Signed-off-by: Vacant2333 <[email protected]>
monkeyDluffy6017
previously approved these changes
Jan 24, 2024
shreemaan-abhishek
previously approved these changes
Jan 24, 2024
Signed-off-by: Vacant2333 <[email protected]>
Vacant2333
dismissed stale reviews from shreemaan-abhishek and monkeyDluffy6017
via
ec0786c
shreemaan-abhishek
approved these changes
Jan 24, 2024
monkeyDluffy6017
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the sh and docs for build/install
APISIXon MacOS, it will be not supportedFixes #
Part of: #10784
Checklist