Clarify logging #167
Open
Clarify logging #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hopefully these changes make logging methods a bit more comprehensible. |
|
I may have become used to the existing logging setup, but to be honest your proposed change doesn't make anything more comprehensible to me. That may just be me. |
|
The changes make it clear which objects control logging. These are DefaultLogger (which currently has a protected log method), Project and ProjectComponent (a superclass of Task, so the latter simply inherits its log method). TraxLiaison sets a Logger, no need for the XSLTLogger. The next step will be to remove the code duplication discussed in #166 by moving the getMailerImplementation to Mailer and passing a Logger to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.