Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undockerize local & CI site builds #634

Merged
merged 4 commits into from
Jul 12, 2022
Merged

Conversation

rossturk
Copy link
Contributor

While I was working on #629, @potiuk recommended moving away from Docker for the functions of site.sh.

This updates the shell script to remove all of the Docker command execution, and makes changes throughout to remove hardcoded paths. It updates the GitHub workflow to install Hugo and Node, and it adds a few steps to the contributor docs to show users how to do the same.

As a side-effect, this makes site.sh and its related tools/processes work on ARM-based macOS machines.

Ross Turk added 3 commits July 10, 2022 23:45
@eladkal
Copy link
Contributor

eladkal commented Jul 11, 2022

Noting that site.sh is to be replaced with Python version
#623

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. As with my intuition - since we are really relying on very simple and straightforward set of dependencies, the need to use docker is limited here and relying on node and hugo installed locally makes perfect sense. This makes things simpler.

@eladkal yeah. We discussed it and I think it is something @Bowrna should adapt in her changes (and it will make it actually a bit easier to test)

@potiuk
Copy link
Member

potiuk commented Jul 12, 2022

I think conflict needs resolving :)

@rossturk
Copy link
Contributor Author

@potiuk ok! cleanup is done now, thanks for merging that other PR!

Fingers crossed. The GitHub workflow does different stuff on merge to main, hope there aren't surprises.

@potiuk
Copy link
Member

potiuk commented Jul 12, 2022

@potiuk ok! cleanup is done now, thanks for merging that other PR!

Fingers crossed. The GitHub workflow does different stuff on merge to main, hope there aren't surprises.

Will there be any surprises, we will fix them :)

@potiuk potiuk merged commit 124cd9a into apache:main Jul 12, 2022
@potiuk
Copy link
Member

potiuk commented Jul 12, 2022

@potiuk ok! cleanup is done now, thanks for merging that other PR!
Fingers crossed. The GitHub workflow does different stuff on merge to main, hope there aren't surprises.

Will there be any surprises, we will fix them :)

BTW. The way I test merges to main (airlfow has VASTLY different workflow when merging) is git push -f my_fork my_branch:main -> this will push your branch as main (i..e. same as merge) and if you configure the same SECRETS that we have in "apache" in your fork + make sure that the "bucket" name is configurable from secret (I think it is) you can test merge workflow in your own fork with relative ease

@potiuk
Copy link
Member

potiuk commented Jul 12, 2022

Merge running https://github.com/apache/airflow-site/actions/runs/2657942667 , let's see.

@potiuk
Copy link
Member

potiuk commented Jul 12, 2022

All good. Build is Green, the website did not blow up :) 👍

@Bowrna
Copy link

Bowrna commented Jul 14, 2022

@rossturk I get an error saying yarn command not found in my local machine( m1 mac os). Am I missing executing any specific step in documentation?

@potiuk
Copy link
Member

potiuk commented Jul 14, 2022

yep. You need yarn to be installed

potiuk pushed a commit that referenced this pull request Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants