-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undockerize local & CI site builds #634
Conversation
Signed-off-by: Ross Turk <[email protected]>
Signed-off-by: Ross Turk <[email protected]>
Signed-off-by: Ross Turk <[email protected]>
Noting that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. As with my intuition - since we are really relying on very simple and straightforward set of dependencies, the need to use docker is limited here and relying on node and hugo installed locally makes perfect sense. This makes things simpler.
@eladkal yeah. We discussed it and I think it is something @Bowrna should adapt in her changes (and it will make it actually a bit easier to test)
I think conflict needs resolving :) |
@potiuk ok! cleanup is done now, thanks for merging that other PR! Fingers crossed. The GitHub workflow does different stuff on merge to main, hope there aren't surprises. |
Will there be any surprises, we will fix them :) |
BTW. The way I test merges to main (airlfow has VASTLY different workflow when merging) is |
Merge running https://github.com/apache/airflow-site/actions/runs/2657942667 , let's see. |
All good. Build is Green, the website did not blow up :) 👍 |
@rossturk I get an error saying |
yep. You need yarn to be installed |
While I was working on #629, @potiuk recommended moving away from Docker for the functions of
site.sh
.This updates the shell script to remove all of the Docker command execution, and makes changes throughout to remove hardcoded paths. It updates the GitHub workflow to install Hugo and Node, and it adds a few steps to the contributor docs to show users how to do the same.
As a side-effect, this makes
site.sh
and its related tools/processes work on ARM-based macOS machines.