Minor improvements to the golang driver #1203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fervidnerd
commented
Aug 30, 2023
fervidnerd
commented
- Migration to Makefile, as it is the most common approach to building golang projects.
- Upgrade antlr parser to 1.13 and migrate imports
- Commit generated parser golang files (these are needed when importing this library for other projects). Otherwise we'll get compilation errors.
* Migration to Makefile, as it is the most common approach to building golang projects. * Upgrade antlr parser to 1.13 and migrate imports * Commit generated parser golang files (these are needed when importing this library for other projects). Otherwise we'll get compilation errors.
|
@fervidnerd Sorry for the delay, would it be possible to get this PR updated to the current master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.