ARTEMIS-5093 support configurable onMessage timeout w/closing consumer #5291
Conversation
jbertram
force-pushed
the
ARTEMIS-5093
branch
from
43f377d
to
2b6fbd1
Compare
| return config.onMessageCloseTimeout; | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
The API docs specify the value set must be greater than zero, but there isn't any validation of that, should there be?
There was a problem hiding this comment.
Hmmm...That comment was left-over from a copy & paste. I went looking through the existing code to see how validation is done for other parameters, and I'm not actually seeing any. I'm continuing my investigation.
There was a problem hiding this comment.
I did look into what it does with that configuration value and since it is passing into a CountdownLatch is seems like it will not trigger an exception but will return immediately so from the standpoint of being able to be set to zero or negative it works, although seems an absurd value to assign.
| boolean ok = future.await(ClientConsumerImpl.CLOSE_TIMEOUT_MILLISECONDS); | ||
| boolean ok = future.await(onMessageCloseTimeout); |
There was a problem hiding this comment.
Is the const CLOSE_TIMEOUT_MILLISECONDS still required?
| public void testMessageHandlerCloseTimeout() throws Exception { | ||
| // create Netty acceptor so client can use new onMessageCloseTimeout URL parameter | ||
| server.getRemotingService().createAcceptor("netty", "tcp://127.0.0.1:61616").start(); | ||
| final int timeout = 1000; |
There was a problem hiding this comment.
does the test work with a lower timeout to reduce the test duration?
There wasn't a clear place to add documentation about this so I'm relying on JavaDoc.