Artemis Console next gen based on hawtIO 4 #5245
Conversation
|
This looks awesome Andy I can't comment on the OpenID implementation as I don't have much context on what is what... but this looks very superior to the current console.. and the current console was not bad. Everything works quite fast.. it's amazing... When can this be merged? |
There was a problem hiding this comment.
I havent had a chance to finish reviewing this in recent days, but I noticed various small issues when I looked mid week. There appear to be various regressions from issues already fixed in #5149, e.g those I did comment on, and others that look likely from peeking at the list of changed files (e.g old poms that were not removed, seem likely to be back again here)
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Upgrade.java
Outdated
Show resolved
Hide resolved
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Upgrade.java
Show resolved
Hide resolved
| ssl.protocol = TLSv1.3 | ||
| ssl.truststore = src/test/resources/hawtio.jks | ||
| ssl.truststorePassword = hawtio | ||
| ssl.keystore = src/test/resources/hawtio.jks | ||
| ssl.keystorePassword = hawtio | ||
| ssl.keyAlias = openid connect test provider | ||
| ssl.keyPassword = hawtio |
There was a problem hiding this comment.
Some of these seem like questionable out-the-box property values to be defining
| The licenses for dependencies sourced from NPM can be found in | ||
| licenses/NPMLicenses.txt |
There was a problem hiding this comment.
Does this file exist? Dont see it being added, or actions to otherwise source it.
…awtio oidc properties file, to get CompareUpgradeTest passing
|
I pushed a couple of commits making similar changes as I had on the earlier PR, to fix some regressions since then. That leaves the comments around the missing licence file being referenced, and the hawtio-oidc.properties file content (and/or it existing at all; didn't previously by default, maybe it still shouldn't?) |
This is a PR to allow developers to build a variant of the latest Artemis Release with the new Artemis Console embedded, for testing. It will not currently merge and isnt intended to. It replaces #5149
I have staged the 1st Artemis Console release candidate, 1.0.0, and this build will use the staged dependency when built.
I will make this PR a draft and update it for each Artemis Release until it is decided to merge into main.