Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undo change as id already set as keyword type #175

Merged
merged 1 commit into from
Jan 15, 2025
Merged

undo change as id already set as keyword type #175

merged 1 commit into from
Jan 15, 2025

Conversation

utas-raymondng
Copy link
Contributor

@utas-raymondng utas-raymondng commented Jan 15, 2025 •
edited
Loading

collection change to keyword type, the id is the same and hence we can simplify

HavierD
HavierD approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@HavierD HavierD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HavierD HavierD merged commit 09f3dd3 into main Jan 15, 2025
2 checks passed
@HavierD HavierD deleted the features/6092-collectionid-sortable branch January 15, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HavierD HavierD HavierD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@utas-raymondng @HavierD