Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - program v4 CLI #3428

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Lichtso
Copy link

@Lichtso Lichtso commented Nov 1, 2024

Problem

The program v4 CLI is missing some features which the program v3 CLI has.

Summary of Changes

New features:

  • Adds --use-rpc option for deployment.
  • Combines deploy and redeploy commands into one.
  • Adds optional upload range parameters --start-offset and --end-offset.
  • Enables partial deployments (so one can restart a failed deployment attempt).

General cleanup:

  • Removes ProgramV4CommandConfig wrapper. This allows us to have access to all the config fields, not just a subset of them.
  • Moves program_location parameter inside process_deploy_program().
  • Combines the underlying ProgramV4CliCommand as well.
  • Inlines build_create_buffer_message(), build_retract_and_truncate_messages() and build_retract_and_deploy_messages().
  • Fixes cargo registry.

@Lichtso Lichtso requested a review from pgarg66 November 1, 2024 19:25
@Lichtso Lichtso marked this pull request as ready for review November 1, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant