forked from solana-labs/solana
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract signer crates #3087
Open
kevinheavey
wants to merge
22
commits into
anza-xyz:master
Choose a base branch
from
kevinheavey:extract-signer-crates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Extract signer crates #3087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
extract-signer-crates
branch
from
October 7, 2024 08:15
2d27cdb
to
d090fb0
Compare
This was referenced Oct 7, 2024
kevinheavey
force-pushed
the
extract-signer-crates
branch
4 times, most recently
from
October 16, 2024 10:50
fc2e791
to
eccfece
Compare
kevinheavey
force-pushed
the
extract-signer-crates
branch
2 times, most recently
from
October 22, 2024 13:36
c1dd543
to
04c1682
Compare
kevinheavey
force-pushed
the
extract-signer-crates
branch
3 times, most recently
from
October 29, 2024 09:05
647adc5
to
1e002af
Compare
kevinheavey
force-pushed
the
extract-signer-crates
branch
from
October 29, 2024 22:15
1e002af
to
52c3b5a
Compare
kevinheavey
force-pushed
the
extract-signer-crates
branch
from
November 1, 2024 08:29
52c3b5a
to
e616a0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana_sdk::signer
needs to be made available outsidesolana_sdk
Summary of Changes
keypair
module optional in solana-signer. This didn't go in its own crate because it seems it's not possible to do so without breaking theSigners
traitkeypair.rs
with a simple inline parserunique_signers
functionThis branches off #2295 so that needs to be merged first