Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract signer crates #3087

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

kevinheavey
Copy link

@kevinheavey kevinheavey commented Oct 6, 2024

Problem

solana_sdk::signer needs to be made available outside solana_sdk

Summary of Changes

  • Rip out the following crates (not putting them in one crate because each one has quite significant dependencies): solana-presigner, solana-seed-derivable, solana-seed-phrase, solana-signer
  • Make the keypair module optional in solana-signer. This didn't go in its own crate because it seems it's not possible to do so without breaking the Signers trait
  • replace serde_json usage in keypair.rs with a simple inline parser
  • remove itertools from the unique_signers function

This branches off #2295 so that needs to be merged first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant