Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only mark status as shrinking when we have something to shrink #2360

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

jeffwashington
Copy link

Problem

for quite some time, we are logging that we are shrinking many times in a row. This is confusing. When shrinking is a no-op, it would be great if we didn't log we were shrinking.

Summary of Changes

only set the active state for shrinking when we have shrinking to do.

Fixes #

@jeffwashington
Copy link
Author

every 100ms:

[2024-08-02T20:09:52.831754728Z INFO  solana_metrics::metrics] datapoint: accounts_db_active shrink=1i
[2024-08-02T20:10:45.944124685Z INFO  solana_metrics::metrics] datapoint: accounts_db_active shrink=1i
[2024-08-02T20:10:46.117909720Z INFO  solana_metrics::metrics] datapoint: accounts_db_active shrink=1i
[2024-08-02T20:10:46.221801874Z INFO  solana_metrics::metrics] datapoint: accounts_db_active shrink=1i
[2024-08-02T20:10:46.323405695Z INFO  solana_metrics::metrics] datapoint: accounts_db_active shrink=1i
[2024-08-02T20:10:46.554298974Z INFO  solana_metrics::metrics] datapoint: accounts_db_active shrink=1i
[2024-08-02T20:10:46.655448371Z INFO  solana_metrics::metrics] datapoint: accounts_db_active shrink=1i
[2024-08-02T20:10:46.756989744Z INFO  solana_metrics::metrics] datapoint: accounts_db_active shrink=1i
[2024-08-02T20:10:46.858530907Z INFO  solana_metrics::metrics] datapoint: accounts_db_active shrink=1i
[2024-08-02T20:11:36.183635962Z INFO  solana_metrics::metrics] datapoint: accounts_db_active shrink=1i
[2024-08-02T20:11:36.367785381Z INFO  solana_metrics::metrics] datapoint: accounts_db_active shrink=1i
[2024-08-02T20:11:36.472325948Z INFO  solana_metrics::metrics] datapoint: accounts_db_active shrink=1i
[2024-08-02T20:11:36.576503676Z INFO  solana_metrics::metrics] datapoint: accounts_db_active shrink=1i
[2024-08-02T20:11:36.678902581Z INFO  solana_metrics::metrics] datapoint: accounts_db_active shrink=1i
[2024-08-02T20:11:36.916842770Z INFO  solana_metrics::metrics] datapoint: accounts_db_active shrink=1i
[2024-08-02T20:11:37.018109622Z INFO  solana_metrics::metrics] datapoint: accounts_db_active shrink=1i
[2024-08-02T20:11:37.119392855Z INFO  solana_metrics::metrics] datapoint: accounts_db_active shrink=1i
[2024-08-02T20:11:37.221043647Z INFO  solana_metrics::metrics] datapoint: accounts_db_active shrink=1i
[2024-08-02T20:12:24.891435918Z INFO  solana_metrics::metrics] datapoint: accounts_db_active shrink=1i

@jeffwashington jeffwashington merged commit eae4987 into anza-xyz:master Aug 2, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants