Bank::check_status_cache: allocate outside read lock (#3394)

anza-xyz · Nov 1, 2024 · cec047d · cec047d
1 parent 04ca408
commit cec047d
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/runtime/src/bank/check_transactions.rs b/runtime/src/bank/check_transactions.rs
@@ -188,11 +188,12 @@ impl Bank {
         lock_results: Vec<TransactionCheckResult>,
         error_counters: &mut TransactionErrorMetrics,
     ) -> Vec<TransactionCheckResult> {
+        // Do allocation before acquiring the lock on the status cache.
+        let mut check_results = Vec::with_capacity(sanitized_txs.len());
         let rcache = self.status_cache.read().unwrap();
-        sanitized_txs
-            .iter()
-            .zip(lock_results)
-            .map(|(sanitized_tx, lock_result)| {
+
+        check_results.extend(sanitized_txs.iter().zip(lock_results).map(
+            |(sanitized_tx, lock_result)| {
                 let sanitized_tx = sanitized_tx.borrow();
                 if lock_result.is_ok()
                     && self.is_transaction_already_processed(sanitized_tx, &rcache)
@@ -202,8 +203,9 @@ impl Bank {
                 }
 
                 lock_result
-            })
-            .collect()
+            },
+        ));
+        check_results
     }
 
     fn is_transaction_already_processed(