fix: 评审问题处理

antvis · Oct 20, 2023 · 70721d3 · 70721d3
1 parent 2522b2d
commit 70721d3
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/packages/li-p2/src/LayerAttribute/components/ScaleSelector/CustomMaPpingColor/index.tsx b/packages/li-p2/src/LayerAttribute/components/ScaleSelector/CustomMaPpingColor/index.tsx
@@ -86,8 +86,8 @@ const CustomMappingColor = (props: CustomMappingColorProps) => {
   const deletePaletteRangeItem = (index: number, position: string | null) => {
     if (dataType === 'number') {
       const _value = customRanges[index];
-
-      const list = customRanges
+      // @ts-ignore
+      const list: CustomMappingColorItem[] = customRanges
         .map((item, _index) => {
           if (index === _index) {
             return undefined;
@@ -115,7 +115,7 @@ const CustomMappingColor = (props: CustomMappingColorProps) => {
             return item;
           }
         })
-        .filter((item) => !isEmpty(item)) as CustomMappingColor[];
+        .filter((item) => !isEmpty(item));
 
       setCustomRanges(list);
     } else {
@@ -126,7 +126,7 @@ const CustomMappingColor = (props: CustomMappingColorProps) => {
   const onChangePaletteRangeItem = (value: (string | number | null)[], color: string, index: number) => {
     if (dataType === 'number') {
       // @ts-ignore
-      const list: CustomMappingColor[] = customRanges.map((item, _index) => {
+      const list: CustomMappingColorItem[] = customRanges.map((item, _index) => {
         if (index === _index) {
           return {
             ...item,
@@ -155,7 +155,7 @@ const CustomMappingColor = (props: CustomMappingColorProps) => {
       setCustomRanges(list);
     } else {
       // @ts-ignore
-      const list: CustomMappingColor[] = customRanges.map((item, _index) => {
+      const list: CustomMappingColorItem[] = customRanges.map((item, _index) => {
         if (index === _index) {
           return {
             ...item,

diff --git a/packages/li-p2/src/LayerAttribute/components/ScaleSelector/helper.ts b/packages/li-p2/src/LayerAttribute/components/ScaleSelector/helper.ts
@@ -7,7 +7,9 @@ const getScaleDataByMappingColors = (list: CustomMappingColorItem[]) => {
   const mapList: { color: string; value: string }[] = [];
   list.forEach((item) => {
     item.value.forEach((_item) => {
-      mapList.push({ color: item.color, value: typeof _item === 'string' ? _item : _item.toString() });
+      if (_item) {
+        mapList.push({ color: item.color, value: typeof _item === 'string' ? _item : _item.toString() });
+      }
     });
   });
 

diff --git a/packages/li-p2/src/LayerAttribute/components/ScaleSelector/type.ts b/packages/li-p2/src/LayerAttribute/components/ScaleSelector/type.ts
@@ -1,6 +1,6 @@
 export type CustomMappingColorItem = {
   color: string;
-  value: (string | number)[];
+  value: (string | number | null)[];
   id?: string;
 };