Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelized attachment downloading + fixed relative URL bug #3

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

CalderWhite
Copy link

Also added .csv and .parquet extensions to valid attachments so you can mass download websites hosting data!

@antsanchez
Copy link
Owner

Thanks for the changes, but you have changed also github.com/antsanchez/ for github.com/CalderWhite

@CalderWhite
Copy link
Author

@antsanchez sorry, that was just for personal use while I was waiting on a response. I can remove that if you are interested in merging in the changes!

@CalderWhite
Copy link
Author

I think there also might be an issue where it never closes all the channels because I often have to ctrl+c when I am done downloading. Haven't gotten around to debugging why I can't gracefully exit (likely some issue with the channels + concurrency)

@CalderWhite
Copy link
Author

Update on that bug, I just ran it on an ubuntu system and it exited perfectly! I might have fixed the bug and forgotten I did...

@antsanchez
Copy link
Owner

Hi, thanks again and sorry for the late reply!
Can you change the path: github.com/antsanchez/ instead of github.com/CalderWhite so I can merge the PR?
About the last fixed bug you commented, it is already included on the PR?

Copy link
Owner

@antsanchez antsanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks again and sorry for the late reply!
Can you change the path: github.com/antsanchez/ instead of github.com/CalderWhite so I can merge the PR?
About the last fixed bug you commented, it is already included on the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants