Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding a new workflow to validate the FlexibleIPAM feature #6879

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

adding a new workflow to validate the FlexibleIPAM feature #6879

wants to merge 1 commit into from

Conversation

KMAnju-2021
Copy link
Contributor

@KMAnju-2021 KMAnju-2021 commented Dec 19, 2024 •
edited by rajnkamr
Loading

@KMAnju-2021 KMAnju-2021 marked this pull request as draft December 19, 2024 06:33
@rajnkamr rajnkamr added this to the Antrea v2.3 release milestone Dec 26, 2024
@KMAnju-2021 KMAnju-2021 force-pushed the add-cncf-runners branch 22 times, most recently from 33a2b50 to 9486da3 Compare January 2, 2025 04:30
antoninbas
antoninbas reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the PR is misleading: we are adding a new workflow to validate the FlexibleIPAM feature. The fact that we use a non-default runner is an "implementation detail".

.github/workflows/kind.yml Outdated Show resolved Hide resolved
ci/kind/install-ipset.sh Outdated Show resolved Hide resolved
ci/kind/kind-setup.sh Outdated Show resolved Hide resolved
ci/kind/kind-setup.sh Show resolved Hide resolved
@KMAnju-2021 KMAnju-2021 changed the title [WIP] adding self-hosted runners [WIP] adding a new workflow to validate the FlexibleIPAM feature Jan 3, 2025
@KMAnju-2021 KMAnju-2021 force-pushed the add-cncf-runners branch 4 times, most recently from cdfed20 to f85bdc9 Compare January 16, 2025 06:25
@KMAnju-2021 KMAnju-2021 requested a review from Atish-iaf January 16, 2025 06:26
@KMAnju-2021 KMAnju-2021 force-pushed the add-cncf-runners branch 2 times, most recently from ebeb982 to 32595a9 Compare January 16, 2025 06:52
@KMAnju-2021 KMAnju-2021 changed the title [WIP] adding a new workflow to validate the FlexibleIPAM feature adding a new workflow to validate the FlexibleIPAM feature Jan 16, 2025
@KMAnju-2021 KMAnju-2021 marked this pull request as ready for review January 16, 2025 07:03
antoninbas
antoninbas reviewed Jan 21, 2025
View reviewed changes
.github/workflows/kind.yml Outdated Show resolved Hide resolved
ci/kind/kind-setup.sh Outdated Show resolved Hide resolved
ci/kind/kind-setup.sh Outdated Show resolved Hide resolved
ci/kind/test-e2e-kind.sh Outdated Show resolved Hide resolved
ci/kind/test-e2e-kind.sh Outdated Show resolved Hide resolved
@KMAnju-2021 KMAnju-2021 force-pushed the add-cncf-runners branch 16 times, most recently from 7431a6d to f9401e7 Compare January 24, 2025 10:41
@KMAnju-2021
adding CNCF runner
d1ba24e 
Signed-off-by: KMAnju-2021 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajnkamr rajnkamr rajnkamr left review comments

@Atish-iaf Atish-iaf Awaiting requested review from Atish-iaf

@antoninbas antoninbas Awaiting requested review from antoninbas

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Antrea v2.3 release
Development

Successfully merging this pull request may close these issues.
3 participants
@KMAnju-2021 @antoninbas @rajnkamr