Render objects and arrays using JSON.stringify() instead of String()
#283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this closes #273.
I adjusted the defaultValRender function in reltab to use JSON.stringify() for objects. This lets Tad show the object's fields instead of just showing
[Object object].In order for copy-pasting to work with this logic, I also changed the
copySelectedRangefunction to use the respective column formatter instead of taking the raw value. For some reason, this doesn't seem to respect custom column formatting rules, but it didn't do that before this change either, so I figured that it's probably out of scope for this PR.