fix: should cleanup styles in useEffect cleanup function #141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React 18 启用
useInsertionEffect
时,切换主题的场景下,样式会先于 token 写入 cache 并插入 dom,因此在某些场景下(比如这个 PR 的测试用例),最新的样式会被 token 卸载清除。解法:把清除 token 样式的逻辑全部放在
useEffect
的 cleanup 方法中执行,这样会保证在渲染的最后执行清除逻辑。