fix: genStyleUtils doesn't work when realToken is undefined #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: getCompUnitless type error
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17 +/- ##
==========================================
- Coverage 84.00% 83.44% -0.56%
==========================================
Files 11 11
Lines 300 302 +2
Branches 73 81 +8
==========================================
Hits 252 252
- Misses 48 50 +2 ☔ View full report in Codecov by Sentry. |
|
并非 dev only ，待重新提 PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
该 PR 主要修复当使用
genStyleUtils时，传入的options.useToken未返回realToken时，空指针导致genStyleUtils无法正常工作。实际上：
options.useToken返回的realToken、cssVar仅被使用于 DEV 环境，不应该影响genStyleUtils的正常运行。