fix: Use color values currently listed in ant-design docs for gray colors
#82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any updates? I want to this pr to be merged. |
|
Guys we need this in our project, please give feedback at least 🙏 |
|
@tonywu6 Conflicting, could you resolve it? Then I will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What & why
Calculate the list of neutral (gray) colors using a separate function so that the colors exported in this package reflect the gray colors currently shown in ant-design's documentation (as of v4.18.4).
Previously the shades of gray from this package are:
#a6a6a6#999999#8c8c8c#808080#737373#666666#404040#1a1a1a#000000#000000which don't match what's provided in the docs, and are also too dark (notice how the last two are black).
With this change, the package instead exports, for
grey:#ffffff#fafafa#f5f5f5#f0f0f0#d9d9d9#bfbfbf#8c8c8c#595959#434343#262626#1f1f1f#141414#000000which makes it possible to use this package for neutral colors while following ant design guidelines.