Added support for creating linux based docker image #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
maintenance
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
github-actions
bot
added
maintenance
github-actions
bot
added
maintenance
waltersma
reviewed
Oct 25, 2024
| @@ -15,7 +15,7 @@ on: | |||
|
|
|||
| env: | |||
| DOCKER_IMAGE_NAME: ghcr.io/ansys/prime | |||
| DOCKER_IMAGE_TAG: '25.1.0.dev19' | |||
| DOCKER_IMAGE_TAG: '25.1.0-test' | |||
There was a problem hiding this comment.
@rchopade7 I would expect this not to be changed for cicd.
waltersma
reviewed
Oct 25, 2024
| # Build the docker image | ||
| print(">>> Building docker image. This might take some time...") | ||
| out = subprocess.run( | ||
| ["docker", "build", "-f", "linux/Dockerfile", "-t", "ghcr.io/ansys/prime:25.1.0-test", "."], |
There was a problem hiding this comment.
Suggested change
| ["docker", "build", "-f", "linux/Dockerfile", "-t", "ghcr.io/ansys/prime:25.1.0-test", "."], | |
| ["docker", "build", "-f", "linux/Dockerfile", "-t", "ghcr.io/ansys/prime:latest", "."], |
waltersma
reviewed
Oct 25, 2024
Comment on lines
+95
to
+109
| # copy parasolid schema | ||
| shutil.copytree( | ||
| os.path.join( | ||
| AWP_ROOT, "commonfiles", "CAD", "Siemens", "Parasolid36.1.212", "linx64", "schema" | ||
| ), | ||
| os.path.join( | ||
| dest_package_path, | ||
| "commonfiles", | ||
| "CAD", | ||
| "Siemens", | ||
| "Parasolid36.1.212", | ||
| "linx64", | ||
| "schema", | ||
| ), | ||
| ) |
There was a problem hiding this comment.
@rchopade7 this looks version specific, can we consider modifying so this will work between all versions going forward?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for creating linux based docker image