FEAT: rpyc integration #859
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
github-actions
bot
added
the
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #859 +/- ##
==========================================
- Coverage 81.02% 80.98% -0.05%
==========================================
Files 36 36
Lines 2272 2272
==========================================
- Hits 1841 1840 -1
- Misses 431 432 +1 |
koubaa
reviewed
Aug 8, 2024
| ): | ||
| """Initialize the server.""" | ||
| self._exited = False | ||
| self._app: mech.App = None |
There was a problem hiding this comment.
use the "BackgroundApp" class to wrap exited, thread, and app. It'll simplify this class
koubaa
requested changes
Aug 8, 2024
github-actions
bot
added
the
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea is to have remote mechanical embedding services using rpyc