Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples for Fluids models #1021

Merged
merged 43 commits into from
Jul 21, 2023
Merged

Add examples for Fluids models #1021

merged 43 commits into from
Jul 21, 2023

Conversation

rafacanton
Copy link
Contributor

@rafacanton rafacanton commented Jul 10, 2023

  • Improved the deep_copy method of the MeshedRegion (the generic _deep_copy in core.py paves the way for future improvements in deep_copy for other types.
  • Added an example to demonstrate averaging in fluid results.

@rafacanton rafacanton added this to the v0.9.0 milestone Jul 10, 2023
@rafacanton rafacanton marked this pull request as draft July 10, 2023 09:50
@rafacanton rafacanton self-assigned this Jul 12, 2023
@rafacanton rafacanton added enhancement New feature or request examples Related to PyDPF-Core examples labels Jul 12, 2023
@rafacanton rafacanton marked this pull request as ready for review July 12, 2023 06:31
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #1021 (4813dc7) into master (5b87a8a) will decrease coverage by 0.32%.
The diff coverage is 65.51%.

@@            Coverage Diff             @@
##           master    #1021      +/-   ##
==========================================
- Coverage   88.50%   88.18%   -0.32%     
==========================================
  Files          78       78              
  Lines        8915     8979      +64     
==========================================
+ Hits         7890     7918      +28     
- Misses       1025     1061      +36     

@rafacanton rafacanton changed the title Add better support for plotting on faces Add examples for Fluids models Jul 13, 2023
# ``PropertyField``, which provides a relationship between the body IDs and the cell zone
# IDs. In this case, each body is only comprised of one cell zone.

minfo.get_property("body_cell_topology")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @rafacanton don't we want to expose realy APIs (with no strings) in the mesh info

@rafacanton
Copy link
Contributor Author

@JennaPaikowsky This PR is ready for review. In particular, could you take a look at the examples/12-fluids files, please? Thanks!

@rafacanton rafacanton closed this Jul 21, 2023
@rafacanton rafacanton reopened this Jul 21, 2023
@rafacanton rafacanton closed this Jul 21, 2023
@rafacanton rafacanton reopened this Jul 21, 2023
@rafacanton rafacanton merged commit 2dd4017 into master Jul 21, 2023
30 of 31 checks passed
@rafacanton rafacanton deleted the rcanton/improve_faces branch July 21, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request examples Related to PyDPF-Core examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants