Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement cut operation in extrude sketch #1510

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

RobPasMue
Copy link
Member

Description

Provide cut argument in extrude_sketch function to allow for subtract operations.

Issue linked

Closes #1503

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Oct 24, 2024
@github-actions github-actions bot added the enhancement New features or code improvements label Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 31.57895% with 13 lines in your changes missing coverage. Please review.

Project coverage is 91.48%. Comparing base (54ca2a0) to head (ad81da8).

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/component.py 29.41% 12 Missing ⚠️
src/ansys/geometry/core/misc/measurements.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1510      +/-   ##
==========================================
- Coverage   91.65%   91.48%   -0.17%     
==========================================
  Files          86       86              
  Lines        6986     7003      +17     
==========================================
+ Hits         6403     6407       +4     
- Misses        583      596      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

PipKat
PipKat previously approved these changes Oct 24, 2024
Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits suggested--although I see this is a draft. I only looked at it because I was copied on the PR. Sorry!

@RobPasMue
Copy link
Member Author

Minor edits suggested--although I see this is a draft. I only looked at it because I was copied on the PR. Sorry!

No problem at all - thanks @PipKat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend extrude-sketch operation to also allow for "cut" operation
3 participants