-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement cut operation in extrude sketch #1510
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1510 +/- ##
==========================================
- Coverage 91.65% 91.48% -0.17%
==========================================
Files 86 86
Lines 6986 7003 +17
==========================================
+ Hits 6403 6407 +4
- Misses 583 596 +13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor edits suggested--although I see this is a draft. I only looked at it because I was copied on the PR. Sorry!
No problem at all - thanks @PipKat! |
Co-authored-by: Kathy Pippert <[email protected]>
Description
Provide
cut
argument inextrude_sketch
function to allow for subtract operations.Issue linked
Closes #1503
Checklist
feat: extrude circle to cylinder
)