Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: testing new static search #1477

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Conversation

RobPasMue
Copy link
Member

TEST PR

@github-actions github-actions bot added maintenance Package and maintenance related enhancement New features or code improvements labels Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.65%. Comparing base (85e5df3) to head (cfd7a2c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1477   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files          86       86           
  Lines        6986     6986           
=======================================
  Hits         6403     6403           
  Misses        583      583           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue self-assigned this Oct 14, 2024
doc/source/conf.py Outdated Show resolved Hide resolved
@jorgepiloto
Copy link
Member

jorgepiloto commented Oct 23, 2024

I can see the search is indexing new nodes. Despite this, the anchors are not correct @Revathyvenugopal162:

Consider the https://geometry.docs.pyansys.com/version/stable/api/ansys/geometry/core/sketch/arc/Arc.html page. If searching for from_three_points, the breadcrumbs are:

Arc > Overview        # This one is valid
Arc > Method detail   # This should point to the right anchor

However, they should be:

Arc > Overview
Arc > Method detail > from_three_point

@Revathyvenugopal162
Copy link
Contributor

Revathyvenugopal162 commented Oct 24, 2024

I can see the search is indexing new nodes. Despite this, the anchors are not correct @Revathyvenugopal162:

Consider the https://geometry.docs.pyansys.com/version/stable/api/ansys/geometry/core/sketch/arc/Arc.html page. If searching for from_three_points, the breadcrumbs are:

Arc > Overview        # This one is valid
Arc > Method detail   # This should point to the right anchor

However, they should be:

Arc > Overview
Arc > Method detail > from_three_point

improved the header and the indexing for api references:

Screenshot 2024-10-24 at 20-25-23 PyAnsys Geometry — PyAnsys Geometry

@jorgepiloto
Copy link
Member

I edited your comment, @Revathyvenugopal162 by attaching the right image. This is working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants