[WIP] Add functional tests

[gbenhaim]

Signed-off-by: gbenhaim [email protected]

[lukas-bednar]

serviceinstance can end up in several states, I usually wait until status.provisionStatus == Provisioned with command
oc get serviceinstances -n kube-system kubevirt -o template --template "{{.status.provisionStatus}}"

and then if this works it doesn't mean that all went good ... I already saw it several times that all tasks were skip and APB just did nothing successfully :-/ ...

The easiest sanity is probably checking version of kubevirt via API curl -X GET -H "Authorization: Bearer $(oc whoami -t)" -k https://localhost:8443/apis/subresources.kubevirt.io/v1alpha2/version

[lukas-bednar]

It would be good also run deprovisioning, I saw it broken many times too.
It is about running delete on serviceinstance which you created in run_apb .

Then you need to wait until kubevirt serviceinstance disappear from cluster and there are no kubevirt pods.

[gbenhaim]

@rthallisey @lukas-bednar Are you familiar with the following error:

error: unable to recognize "/tmp/tmp.zCQ296uYKf": no matches for kind "ServiceInstance" in version "servicecatalog.k8s.io/v1beta1"
?

[rthallisey]

That seems like the service catalog didn't start correctly. I would print out the pods and see if the catalog is running.

[lukas-bednar]

@gbenhaim I am familiar with two issues related to ASB

1. Sometimes asb-deploy pod ends up in Error stage, and ASB never get provisioned, I run following task until it gets deployed successfully

---
- name: "Wait until ASB is running"
  shell: |
    set -o pipefail
    set -e
    # If asb-X-deploy ended in Error, remove it and redeploy it again
    if oc get pods -n openshift-ansible-service-broker | grep deploy | grep Error ;
    then
      oc delete pods -n openshift-ansible-service-broker $(oc get pods -n openshift-ansible-service-broker | grep deploy | cut -f 1 -d ' ')
      oc rollout latest asb -n openshift-ansible-service-broker
    fi
    # If ASB is not running exit with 1
    if ! oc get pods -n openshift-ansible-service-broker | grep -v deploy | grep Running ;
    then
      exit 1
    fi
  register: asb_status
  until: asb_status.rc == 0
  retries: 60
  delay: 15

2. There is open issue related to ASB route timeout ...

---
- name: "Apply WA for https://github.com/openshift/ansible-service-broker/issues/876"
  shell: |
    set -e
    oc annotate route -n openshift-ansible-service-broker asb-1338 --overwrite haproxy.router.openshift.io/timeout=300s